#212 output channels list in story/media profile out of context - Bricolage

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

#212 ✓ resolved

output channels list in story/media profile out of context

Reported by Zdravko Balorda | October 19th, 2010 @ 06:29 AM | in 2.0.1

The story profile page involves a section for assigning OC to a story. As it is
all OC associated to a Story element are listed regardless of site context. Proper
behaviour would be to list only OC associated to a story site only. I suggest a fix
for this:

% my $sid = $story->get_site_id; % my $all_ocs = [
% grep { $->get_site_id == $sid && !$curr_ocs->{$->get_id} && chk_authz($_, READ, 1) }
% grep { ! $curr_ocs->{$->get_id} && chk_authz($, READ, 1) } % $story->get_element_type->get_output_channels % ]; in comp/widgets/story_prof/list_output_channels.html. The same goes for media profile.

Regards, Zdravko

Comments and changes to this ticket

phillipadsmith October 30th, 2010 @ 12:05 AM
- State changed from “new” to “hold”
- Milestone set to “2.0.1”
- Milestone order changed from “9” to “0”
The story profile page involves a section for assigning OC to a story. As it is all OC associated to a Story element are listed regardless of site context. Proper
behaviour would be to list only OC associated to a story site only. I suggest a fix
for this:

Hey there Zdravko,

Would you be able to provide this as a patch, or pull request in Github? Would make it much easier to test and commit.

Phillip.
Zdravko Balorda January 26th, 2011 @ 02:20 PM
Yes, I added last commit to my fork "zdravko" on guthub. I hope you will
be able to pull it out. I am new to this and huh...

Zdravko
Bugs (at bricolage) January 26th, 2011 @ 05:02 PM
- State changed from “hold” to “open”
- Assigned user changed from “Bugs (at bricolage)” to “theory”
Bugs (at bricolage) January 26th, 2011 @ 07:51 PM
- State changed from “open” to “resolved”
(from [a98bc7d303403146fbdbfec255165aaa066746fc]) Credit Zdravko Balorda for fixing Bug # 212.

[#212 state:resolved] https://github.com/bricoleurs/bricolage/commit/a98bc7d303403146fbdb...

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.