Bricolage Bricolage → 2.0.1

Comments and changes to this ticket

• 

  phillipadsmith October 29th, 2010 @ 11:32 PM

  • State changed from “new” to “hold”
  • Milestone set to “2.0.1”
  • Milestone order changed from “6” to “0”

  Deactivated assets can still be selected for "republishing" via the UI but are not actually republished. When these stories are selected (via checkboxes) and the "Publish Checked" button pressed these assets are are not shown on the publish details page.

  Michael,

  Can you give me a bit more information on this bug? I'm not able to re-create it on 2.x This is what I see: http://screencast.com/t/JqsTJMvQs0s

• 

  Michael Herring November 1st, 2010 @ 03:03 PM

  Phillip,

  In our proof of concept migration box (upgrade from 1.10.9 to 2.0.0) this problem is still exhibited [see attached image].

  I believe the issue is related to the Bricolage configuration option in 2.0.0 EXPIRE_ON_DEACTIVATE (which we have backported to our production 1.10.9 instance). When that directive is on the need to re-publish deactivated assets does not exist and the checkbox should be hidden as no publish jobs are created. If the directive is off then the option is valid and should republish the deactivated assets because they would be left on the server unless expired.

  Does this help?

  -Michael

  • bug201.PNG 91.6 KB
• 

  phillipadsmith November 3rd, 2010 @ 02:24 PM

  Does this help?

  I think I see the issue: You're referring specifically to once published but now deactivated assets, yes? I see in your most recent screenshot that assets that were never published appear as they do in my screenshot (with only the "reactivate" button), but assets with a red "P" have both options.

  If that's the case, I can try to reproduce this again... please confirm. :)

  Phillip.

• 

  Michael Herring November 3rd, 2010 @ 05:42 PM

  Phillip,

  That is correct.

  -Michael

• 

  Michael Herring November 12th, 2010 @ 07:13 PM

  After some more digging it appears this issue may be the symptom of a larger coherence problem in Bricolage where the publish status, publish_version, etc.. fields of a story (possibly media and/or templates) are not properly updated after the story is expired.

• 

  Michael Herring November 15th, 2010 @ 09:00 PM

  • Tag changed from “1.10.9, deactived, republish” to “1.10.9, deactivated, republish”

  See bug #216 for what I believe is the root cause of this bug.

• 

  Michael Herring November 30th, 2010 @ 04:11 PM

  Phillip, were you ever able to reproduce this problem?

• 

  phillipadsmith January 17th, 2011 @ 09:08 PM

  Phillip, were you ever able to reproduce this problem?

  Yes, I believe I'm able to reproduce it:

  • Publish some stories
  • Find those stories, deactivate (delete) them
  • Find those stories again, now they have two checkboxes beside them: Reactivate and Republish
  • Checking Republish and then clicking "Publish Checked" at the bottom of the list sends the user to the Workflow | Publish screen with no assets showing.

  I get the same checkbox options regardless of how the 'Expire on deactivate' configuration setting is set.

  Given the above behaviour, I would say this is a bug. (Not sure what the fix is, however.)

• 

  phillipadsmith January 17th, 2011 @ 09:11 PM

  • State changed from “hold” to “open”
• 

  Nick Legg January 18th, 2011 @ 04:16 PM

  Per a brief discussion between myself, theory, and phillipadsmith yesterday it was decided that deactivated assets should not have the "Republish" checkbox. This is an extremely simple fix: https://github.com/bricoleurs/bricolage/pull/17

• 

  Bugs (at bricolage) January 18th, 2011 @ 07:01 PM

  • State changed from “open” to “resolved”

  (from [331c8de2a3223dca3349e3e665fd61bb8ddd8270]) Fixed #201: Deactived assets still have "Republish" checkbox in UI when using "Find Stories" https://github.com/bricoleurs/bricolage/commit/331c8de2a3223dca3349...

• 

  Bugs (at bricolage) January 18th, 2011 @ 07:01 PM

  (from [e85e210f493a3046f34350a7d30c31232ddbdf7c]) Fixed #201: Deactived assets still have "Republish" checkbox in UI when using "Find Stories" https://github.com/bricoleurs/bricolage/commit/e85e210f493a3046f343...

• 

  Bugs (at bricolage) January 18th, 2011 @ 07:04 PM

  (from [905f6793fe21134c6101612cddad0d90d2f78eb8]) Fixed #201: Deactived assets still have "Republish" checkbox in UI when using "Find Stories" https://github.com/bricoleurs/bricolage/commit/905f6793fe21134c6101...