#174 Installed Apache modules missed during installation due to relative paths - Bricolage

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

#174 ✓ resolved

Installed Apache modules missed during installation due to relative paths

Reported by Michael Herring | May 25th, 2010 @ 03:00 PM | in 2.0.1

When checking for required Apache modules the inst/htprobe_apache2.pl fails to slurp up additional apache conf files defined within httpd.conf which may result in Bricolage failing to find a required but installed module.

This problem occurred for me with both Centos 5.4 and Ubuntu 9.10 when checking mod_apreq2. I'm currently working with a vanilla Bricolage 2.0 install.

I've attached a patch which addresses the issue.

conf_slurp_patch.diff 411 Bytes

Comments and changes to this ticket

theory May 25th, 2010 @ 05:03 PM
- Milestone set to “2.1.0”
Your patch is a start, but it might find non-httpd configuration files and perhaps parse errors. Better would be to recognize the Include directive in the initial file and pull in and parse such files.

Just MHO.

David
Michael Herring May 25th, 2010 @ 05:26 PM
David,

The current htprobe_apache2.pl locates the httpd.conf then looks for the Include directive but fails to pull in those confs if the include directive value is a relative path. The patch just tries to convert the relative path to an absolute path using the HTTPD_ROOT as a prefix to the Include directive value.

-Michael
theory May 25th, 2010 @ 05:28 PM
- Milestone changed from “2.1.0” to “2.0.1”
- State changed from “new” to “open”
Oh, that seems to make sense. Hell, I think it should probably be considered a bug fix.

Thanks!

David
Bugs (at bricolage) January 17th, 2011 @ 08:13 PM
- State changed from “open” to “resolved”
- Milestone order changed from “0” to “0”
(from [909f8ebff3144175a98f09af724c2f99cf14cbc7]) Find Apache 2 Included conf files by relative path.

[#174 state:resolved] https://github.com/bricoleurs/bricolage/commit/909f8ebff3144175a98f...
Bugs (at bricolage) January 17th, 2011 @ 08:13 PM
(from [486e302f0ed0585bf903e464997001c2ad60f399]) Find Apache 2 Included conf files by relative path.

[#174 state:resolved] https://github.com/bricoleurs/bricolage/commit/486e302f0ed0585bf903...

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

People watching this ticket

Attachments

conf_slurp_patch.diff 411 Bytes

Referenced by

#174 Installed Apache modules missed during installation due to relative paths [#174 state:resolved] https://github.com/bricoleurs/bric...
#174 Installed Apache modules missed during installation due to relative paths [#174 state:resolved] https://github.com/bricoleurs/bric...

Bricolage Bricolage → 2.0.1