#144 ✓ resolved
Zdravko Balorda

Expired status issue

Reported by Zdravko Balorda | March 10th, 2010 @ 08:28 AM | in 1.11.4

well, this is more "is it a bug or a feature" question. Expired sotries can't be published,
yet $burner->best_uri is happy to return URI to expired story. This can priduce broken
links if expired story is related to some other.

I beleive also that the expire status should not have any impact on publishing stories. As it is now, it's just another method to delete a story. Maybe I don't understand the concept behind it, but for my site I need to add another "archive date" field to achieve something that expire date seems to be perfect for. My suggestion thus is to treat expired stories much the same way as any other. (except perhaps for limiting the search) There wil be no broken links, while designer can treat differently hot stories and expired ones.

Comments and changes to this ticket

  • theory

    theory March 10th, 2010 @ 07:28 PM

    • State changed from “new” to “open”
    • Tag set to best_uri, expire, publish
    • Milestone set to 1.11.4
  • theory

    theory March 10th, 2010 @ 08:05 PM

    So expiring stories is not the same as deleting them. All it does is remove them from the site; they still exist in Bricolage. Now if you have the EXPIRE_ON_DEACTIVATE bricolage.conf directive enabled, documents are automatically expired when you delete them. But the reverse is not true.

    But I do think it makes sense to avoid expired aliases. Does this patch do what you want?

    --- a/lib/Bric/Util/Burner.pm
    +++ b/lib/Bric/Util/Burner.pm
    @@ -1941,6 +1941,7 @@ sub best_uri {
         } else {
             # The asset's not in this site. Try to lookup an alias in this site.
             if (my $rel = $ba->lookup({ alias_id => $ba->get_id,
    +                                    unexpired => 1,
                                         site_id  => $site_id })) {
                 # Use the alias, instead.
                 $ba = $rel;
    
  • Bugs (at bricolage)

    Bugs (at bricolage) March 10th, 2010 @ 08:08 PM

    • State changed from “open” to “resolved”

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

People watching this ticket

Referenced by

Pages