Bricolage Bricolage → 2.0.2

Comments and changes to this ticket

• 

  theory February 25th, 2011 @ 04:35 PM

  • Tag changed from “2.0.1, view” to “2.0.1, ie7, ie8, ui, view”
  • State changed from “new” to “open”
  • Milestone set to “2.0.2”
• 

  Nick Legg March 24th, 2011 @ 02:57 PM

  Confirming this behavior in IE9 and Firefox 4.0. It behaves properly in Firefox 3.6 and older, as far as I can tell.

• 

  Greg Heo May 9th, 2011 @ 08:31 PM

  • Assigned user changed from “Bugs (at bricolage)” to “phillipadsmith”
  • Milestone order changed from “2” to “0”
• 

  theory December 2nd, 2011 @ 04:31 AM

  • Assigned user changed from “phillipadsmith” to “theory”
  • Milestone order changed from “3” to “0”

  Broken by this commit. It seems that this was designed to address the "diff" button not working on IE, but at some point Firefox (I'm running 7.01) started submitting the numbers in the field, thus breaking it. The question is, does reverting it fix IE? Will diffs stop working in IE?

  I'm going to commit a change that removes the check for an integer in the field value and see what happens.

• 

  theory December 2nd, 2011 @ 04:35 AM

  I can confirm that removing that code fixes the issue, but then the Return button in the diff page returns to the wrong page. In Firefox 7. Will see if I can get them both working, and then hopefully it will fix IE, too.

• 

  theory December 2nd, 2011 @ 04:44 AM

  This is only going to get worse. Need to come up with a better solution.

• 

  Bugs (at bricolage) December 2nd, 2011 @ 05:03 AM

  (from [0d6c5651b42d680c64323e0f52686e1f4a74f5e0]) Fix Back button when viewing an asset.

  Has been broken by the HTML 5 standard, which has image inputs no longer submit their values, but their .x and .y positions. This is annoying, and more like how IE has always behaved. In this commit (and others like it for media nd templates), Scott fixed a bug related to get the Return button to work on the diff view. Removing that change fixes the view Return button, but breaks the Diff return button. So switch to using a very simple image link for the Diff page return button instead of the image input. That works on any browser, and so now the Return button should work properly both when viewing assets and when viewing diffs.

  [#240 state:closed] https://github.com/bricoleurs/bricolage/commit/0d6c5651b42d680c6432...

• 

  Bugs (at bricolage) December 2nd, 2011 @ 05:03 AM

  (from [6fbfbac9b29eb3ec9f2e4d4f0d9168c1187d9e75]) Fix Back button when viewing an asset.

  Has been broken by the HTML 5 standard, which has image inputs no longer submit their values, but their .x and .y positions. This is annoying, and more like how IE has always behaved. In this commit (and others like it for media nd templates), Scott fixed a bug related to get the Return button to work on the diff view. Removing that change fixes the view Return button, but breaks the Diff return button. So switch to using a very simple image link for the Diff page return button instead of the image input. That works on any browser, and so now the Return button should work properly both when viewing assets and when viewing diffs.

  [#240 state:closed] https://github.com/bricoleurs/bricolage/commit/6fbfbac9b29eb3ec9f2e...

• 

  theory December 2nd, 2011 @ 07:09 AM

  • State changed from “open” to “resolved”