#240 ✓ resolved
Michael Herring

Return button fails when viewing assets in IE7/IE8

Reported by Michael Herring | February 25th, 2011 @ 03:23 PM | in 2.0.2

Clicking "Return" button after viewing an asset in IE7 or IE8 fails. The user is continually shown the "View" of an asset and is not taken back to there previous location in the application (desk, workspace, etc...). Other browsers like Firefox and Safari work properly.

Steps to reproduce:
1. In IE7/IE8 login to Bricolage and find an asset
2. Click the "View" option
3. Click the "Return button at the bottom of the page

This behavior is observed in Bricolage 2.0.1

Comments and changes to this ticket

  • theory

    theory February 25th, 2011 @ 04:35 PM

    • Tag changed from 2.0.1, view to 2.0.1, ie7, ie8, ui, view
    • State changed from “new” to “open”
    • Milestone set to 2.0.2
  • Nick Legg

    Nick Legg March 24th, 2011 @ 02:57 PM

    Confirming this behavior in IE9 and Firefox 4.0. It behaves properly in Firefox 3.6 and older, as far as I can tell.

  • Greg Heo

    Greg Heo May 9th, 2011 @ 08:31 PM

    • Assigned user changed from “Bugs (at bricolage)” to “phillipadsmith”
    • Milestone order changed from “2” to “0”
  • theory

    theory December 2nd, 2011 @ 04:31 AM

    • Assigned user changed from “phillipadsmith” to “theory”
    • Milestone order changed from “3” to “0”

    Broken by this commit. It seems that this was designed to address the "diff" button not working on IE, but at some point Firefox (I'm running 7.01) started submitting the numbers in the field, thus breaking it. The question is, does reverting it fix IE? Will diffs stop working in IE?

    I'm going to commit a change that removes the check for an integer in the field value and see what happens.

  • theory

    theory December 2nd, 2011 @ 04:35 AM

    I can confirm that removing that code fixes the issue, but then the Return button in the diff page returns to the wrong page. In Firefox 7. Will see if I can get them both working, and then hopefully it will fix IE, too.

  • theory
  • Bugs (at bricolage)

    Bugs (at bricolage) December 2nd, 2011 @ 05:03 AM

    (from [0d6c5651b42d680c64323e0f52686e1f4a74f5e0]) Fix Back button when viewing an asset.

    Has been broken by the HTML 5 standard, which has image inputs no longer submit their values, but their .x and .y positions. This is annoying, and more like how IE has always behaved. In this commit (and others like it for media nd templates), Scott fixed a bug related to get the Return button to work on the diff view. Removing that change fixes the view Return button, but breaks the Diff return button. So switch to using a very simple image link for the Diff page return button instead of the image input. That works on any browser, and so now the Return button should work properly both when viewing assets and when viewing diffs.

    [#240 state:closed] https://github.com/bricoleurs/bricolage/commit/0d6c5651b42d680c6432...

  • Bugs (at bricolage)

    Bugs (at bricolage) December 2nd, 2011 @ 05:03 AM

    (from [6fbfbac9b29eb3ec9f2e4d4f0d9168c1187d9e75]) Fix Back button when viewing an asset.

    Has been broken by the HTML 5 standard, which has image inputs no longer submit their values, but their .x and .y positions. This is annoying, and more like how IE has always behaved. In this commit (and others like it for media nd templates), Scott fixed a bug related to get the Return button to work on the diff view. Removing that change fixes the view Return button, but breaks the Diff return button. So switch to using a very simple image link for the Diff page return button instead of the image input. That works on any browser, and so now the Return button should work properly both when viewing assets and when viewing diffs.

    [#240 state:closed] https://github.com/bricoleurs/bricolage/commit/6fbfbac9b29eb3ec9f2e...

  • theory

    theory December 2nd, 2011 @ 07:09 AM

    • State changed from “open” to “resolved”

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.

New-ticket Create new ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Pages